docs: add new Prerequisites #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leohhhn
approved these changes
Mar 4, 2024
Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
leohhhn
added a commit
to leohhhn/gno
that referenced
this pull request
Mar 6, 2024
<!-- please provide a detailed description of the changes made in this pull request. --> I propose this change in the prerequisites of the [getting-started](https://docs.gno.land/getting-started/local-setup) because @kazai777 and I (mac apple silicon users) encountered a `command not found` with the given commands. And by checking with `echo $GOPATH`, the path was empty. We noticed that in the newer versions of Go, one must manually add the path. However, thanks to @mous1985 , we saw that on Ubuntu, it was set automatically. Warning -> this also needs to be verified on Windows. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: théo dub <theodub@MacThox.local> Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose this change in the prerequisites of the getting-started because @kazai777 and I (mac apple silicon users) encountered a
command not foundwith the given commands. And by checking withecho $GOPATH, the path was empty. We noticed that in the newer versions of Go, one must manually add the path.However, thanks to @mous1985 , we saw that on Ubuntu, it was set automatically.
Warning -> this also needs to be verified on Windows.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description